Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari version number changed to build number #17111

Closed
mstroeve opened this issue Apr 15, 2024 · 3 comments
Closed

Safari version number changed to build number #17111

mstroeve opened this issue Apr 15, 2024 · 3 comments
Labels
bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite kind/bug 🐞 mode/spa Qv2 🔝 Quasar v2 issues

Comments

@mstroeve
Copy link

What happened?

We updated Quasar V2 (previous was approx. 2 months ago) but the browser.version is giving different results.
It used to give a safari version like 17.3 but now its returning a weird (webkit? ) version number instead.

This screenshot below is from a mac device accessing: https://quasar.dev/options/platform-detection

Scherm­afbeelding 2024-04-15 om 21 43 16

What did you expect to happen?

Show the actual safari version number like 17.5

Reproduction URL

https://codepen.io/pen?&editors=101

How to reproduce?

Visit https://quasar.dev/options/platform-detection using a macOS/iOS device

Flavour

Quasar CLI with Vite (@quasar/cli | @quasar/app-vite)

Areas

SPA Mode

Platforms/Browsers

Safari, iOS

Quasar info output

No response

Relevant log output

No response

Additional context

No response

@mstroeve mstroeve added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Apr 15, 2024
@github-actions github-actions bot added bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite mode/spa labels Apr 15, 2024
@rstoenescu
Copy link
Member

Nothing changed in Quasar in regards to the version detection, but the UserAgent string changed in Safari itself. Regardless, fix is coming.

@rstoenescu
Copy link
Member

Fix will be available in Quasar v2.15.3

@mstroeve
Copy link
Author

Thanks for the quick fix, made a donation.
We are looking into options for supporting the project in long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite kind/bug 🐞 mode/spa Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

2 participants