Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add network override CLI option #1194

Closed
popey opened this issue May 10, 2024 · 1 comment
Closed

feat: Add network override CLI option #1194

popey opened this issue May 10, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@popey
Copy link
Collaborator

popey commented May 10, 2024

Expected behavior

Sometimes I'd like to override the network behaviour of quickemu. Specifically I'd like to disconnect the network, or change to a bridged network.

Something like this:

quickemu --network none

or

quickemu --network bridged

Actual behavior

There's no option to do this.

Thanks!

@flexiondotorg flexiondotorg added enhancement New feature or request good first issue Good for newcomers labels May 10, 2024
@flexiondotorg flexiondotorg self-assigned this May 11, 2024
@flexiondotorg
Copy link
Member

flexiondotorg commented May 11, 2024

From talking with you, I think all you really care about is configuring an offline state.

How does this sound? I'm just going to add a --offline argument, which overrides any network configuration with none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

2 participants