bug: --monitor-cmd always fails due to qemu-img check attempt

[philclifford]

Expected behavior

--monitor-cmd works as documented

Actual behavior

--monitor-cmd (and presumably other options that work with a running VM) break due to invocation of qemu-img to check the disk, which of course fails as it is in use.

[flexiondotorg]

This regress was introduced via:

• d030221

In an effort to fix #848

Thanks @philclifford for this comment:

• feat: Please add an option to kill the VM from the command line #1195 (comment)

Here's some more activity for the disk health check:

• 59865c8
• d680eec

[flexiondotorg]

The disk health check is a feature that is broken by design: #848

• If a VM is running, qemu-img check will always fail because it can not get a write lock
• quickemu can start VMs in the background (--display spice, for example), and the health check then breaks all further use of quickemu that operates on that running VM.

[TuxVinyards]

This is a general test that I use for my disk maintenance routines to avoid Qemu lock problems.

    # use pgrep with -x exact match to avoid 'kvm-cleanup' processes being detected
    [[ $(pgrep -x kvm) ]] &&  printColor "\n\n  VIRTUAL MACHINE ACTIVITY has been DETECTED \n"   

Thinking aloud a bit here, as just got back from a short break and I haven't tested. But would adding this as a conditional to the disk health checker work?

Edit

The disk health check is a feature that is broken by design: #848

That was fixed in #993 with the addition of an if exist .... So add another, if no kvm ...

[flexiondotorg]

The implementations, as submitted to quickemu in #848 and #993, are both broken. Here is a working implementation: 5ec5c51