Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use session-specific log where possible #392

Open
chrjohn opened this issue May 4, 2021 · 0 comments · May be fixed by #746
Open

Use session-specific log where possible #392

chrjohn opened this issue May 4, 2021 · 0 comments · May be fixed by #746
Assignees
@chrjohn
Labels
enhancement
Milestone
QFJ 3.0.0

Comments

@chrjohn
Copy link
Member

chrjohn commented May 4, 2021

For some error cases there only is a message logged to the general log. But it would be beneficial to see such errors in the session-specific log file.

Example where the SessionID is available but only the general log is used:

quickfixj/quickfixj-core/src/main/java/quickfix/mina/initiator/AbstractSocketInitiator.java

Line 185 in 9bdd8b8

log.warn("error during session initialization for {}, continuing...", sessionID, e);

@chrjohn chrjohn added this to the QFJ 3.0.0 milestone May 4, 2021
@chrjohn chrjohn self-assigned this Jan 2, 2024
@chrjohn chrjohn linked a pull request Jan 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrjohn chrjohn

Labels
enhancement
Projects
None yet
Milestone
QFJ 3.0.0
Development

Successfully merging a pull request may close this issue.

Changed logging to use session-specific log where applicable quickfix-j/quickfixj
1 participant
@chrjohn