Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting some bool env vars to "0" or "false" evaluates to true #4943

Open
guilload opened this issue May 6, 2024 · 0 comments
Open

Setting some bool env vars to "0" or "false" evaluates to true #4943

guilload opened this issue May 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@guilload
Copy link
Member

guilload commented May 6, 2024

We tend to use this pattern, which evaluates to true for any value as long as the en var is set, but sometimes when users want to revert the behavior, they use the value 0 or false instead of unsetting, which does not do anything.

env::var::("QW_IS_*").is_ok()

The following en vars have this issue:

  • QW_S3_FORCE_PATH_STYLE_ACCESS
  • QW_DISABLE_TELEMETRY
  • QW_ENABLE_INGEST_V2
  • QW_DISABLE_INGEST_V1
  • QW_DISABLE_DELETE_TASK_SERVICE

There might be more.

@guilload guilload added the bug Something isn't working label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant