Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use windows-bindgen crate to limit downloads/version bumps #1525

Open
djc opened this issue Apr 3, 2023 · 2 comments
Open

Use windows-bindgen crate to limit downloads/version bumps #1525

djc opened this issue Apr 3, 2023 · 2 comments
Labels

Comments

@djc
Copy link
Collaborator

djc commented Apr 3, 2023

The windows project now exposes a crate that lets us build the bindings we need without the need to depend on all of them (with large downloads and regular version bumps). Would be nice to have.

@Ralith
Copy link
Collaborator

Ralith commented Apr 3, 2023

Hmm, wouldn't that compromise sharing with other crates? I guess we need very few definitions so maybe that's fine.

@djc
Copy link
Collaborator Author

djc commented Apr 4, 2023

Yeah, kind of the point is that most crates using the windows-sys stuff only need a tiny fraction of the bindings, so distributing everything to everyone is kind of pointless. Duplicating thin wrappers governed through a central code generator seems like a superior solution to me.

@djc djc added good first issue Good for newcomers Hacktoberfest labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants