Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientConfig transport and ServerConfig transport have different visibility #1714

Open
BlinkyStitt opened this issue Dec 3, 2023 · 3 comments

Comments

@BlinkyStitt
Copy link

ClientConfig's transport has pub(crate), while ServerConfig's transport has pub. Is this difference intentional? I think both should be pub so that updating the client's transport is easier (unless I'm not supposed to be doing that? I'm new to this).

BlinkyStitt added a commit to BlinkyStitt/quic-tunnel that referenced this issue Dec 3, 2023
@Ralith
Copy link
Collaborator

Ralith commented Dec 4, 2023

The intention is that you should generally use the setter methods. Does that work for your case? Perhaps we should privatize the ServerConfig fields for consistency.

@BlinkyStitt
Copy link
Author

Consistency was my main reason for opening the issue.

I don't remember exactly what was missing now, but I think the setters that exist were missing something.

@Ralith
Copy link
Collaborator

Ralith commented Apr 4, 2024

Every time I try to clean this up it turns out to be more complicated than I expected, but we should definitely try to be consistent one way or another here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants