You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of #1486 I noticed that since #973 the alpha-sorted modulesList variable is effectively no longer used. Instead, the dropdown menu reflects the order in which tests are registered and executed.
It's not clear to me whether this change was made intentionally. What do you think? Is it better to function as a table of contents and match the order of results on the page, or to function as its own (alpha) sorted index?
Note that parent/child modules will still remain together either way since we use the full name in this menu, which starts with Parent module > .
The text was updated successfully, but these errors were encountered:
Follows-up 0780127, which changed the code to use
QUnit.config.modules directly. This meant the list is no longer
sorted, however. I filed #1487
to look into that.
Depending on the outcome of that, we can bring this back in some form
after the refactoring of #1487.
Follows-up 0780127, which changed the code to use
QUnit.config.modules directly. This meant the list is no longer
sorted, however. I filed #1487
to look into that.
Depending on the outcome of that, we can bring this back in some form
after the refactoring of #1487.
Follows-up 0780127, which changed the code to use
QUnit.config.modules directly. This meant the list is no longer
sorted, however. I filed #1487
to look into that.
Depending on the outcome of that, we can bring this back in some form
after the refactoring of #1487.
Basically, we now only show 20 items at most, and whenever something is typed in the field, the order is determined by fuzzysort ranking which is neither defined order nor alphabetical order.
For the initial 20 items, we simply take the first 20 that were defined which was simply the most efficient way to implement it. That could potentially be changed if there was interest, but I think for this issue it is resolved.
As part of #1486 I noticed that since #973 the alpha-sorted
modulesList
variable is effectively no longer used. Instead, the dropdown menu reflects the order in which tests are registered and executed.It's not clear to me whether this change was made intentionally. What do you think? Is it better to function as a table of contents and match the order of results on the page, or to function as its own (alpha) sorted index?
Note that parent/child modules will still remain together either way since we use the full name in this menu, which starts with
Parent module >
.The text was updated successfully, but these errors were encountered: