-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect comments in some public member documentation #1109
Comments
@domicioam please understand that when we suggest opening a pull request to fix issues it is to confirm that yes, the issue is valid and that yes, we would appreciate a contribution to fix it. |
Hello Luke, I am not sure if that was the intention. I felt like the other guy was calling me lazy for reporting it instead of fixing it. I would gladly fix the comments if I was familiar with the library, but the best I could do at the time was to report the issue. Thanks for the heads up anyways. It is good to learn the jargon of open source projects. Kind regards, |
I am certain that @michaelklishin's intention is to suggest contributing to the library, not suggest anyone is lazy. The RabbitMQ core team (I'm part of it) receives many issue reports across a large number of repositories here on GitHub. A fraction of those (like yours) are legitimate and we suggest opening pull requests in case people are hesitant to do so. If an issue doesn't require a fix we say so as well. In general, open-source project maintainers may seem abrupt with their comments but it's best to take them at face value rather than reading into them. We're all busy with our day jobs! |
@domicioam I did not imply that anyone is lazy. It's a perfectly common thing to suggest for a maintainer: if the problem is well understood, the reporter might as well submit a PR. |
These particular XML comments appear to be correct in |
User @domicioam noticed the following incorrect comments in #1105:
The text was updated successfully, but these errors were encountered: