-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Roslyn analyzers #1269
Milestone
Comments
Example of what an analyzer might catch: #1347 (comment) |
lukebakken
added a commit
that referenced
this issue
Dec 18, 2023
Reference: #1269 Use the same API analysis tool that is used in the RabbitMQ.Stream.Client library.
lukebakken
added a commit
that referenced
this issue
Dec 19, 2023
Reference: #1269 * Use the same API analysis tool that is used in the RabbitMQ.Stream.Client library. * Remove existing APIApproval tests. Replaced by PublicApiAnalyzers. * Add retries when connection can't be open due to a `SocketException`. * Change Windows GitHub actions runner to windows-2019. It should be faster and may not have that socket exception * Add connection retries for SocketException to SSL tests. Uncovered with windows 2019.
These should eventually be enabled:
|
lukebakken
added a commit
that referenced
this issue
Dec 19, 2023
Reference: #1269 * Use the same API analysis tool that is used in the RabbitMQ.Stream.Client library. * Remove existing APIApproval tests. Replaced by PublicApiAnalyzers. * Add retries when connection can't be open due to a `SocketException`. * Change Windows GitHub actions runner to windows-2019. It should be faster and may not have that socket exception * Add connection retries for SocketException to SSL tests. Uncovered with windows 2019.
Related old issue - #444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://devblogs.microsoft.com/dotnet/configureawait-faq/
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2007?view=vs-2019
dotnet/roslyn-analyzers#6757
The text was updated successfully, but these errors were encountered: