topology : fix connection factory property evaluation #724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
You can't set topology recovery using the CF configurator unless you do a trick like
-Dtrue=true
in JVM argsThis PR is following quarkiverse/quarkus-rabbitmq-client#85 because of the root commit at e9b642f#diff-3ee7482ebddb8471bf938e29cb3b8d0704c94e0cf94fe6a67593149b99f38c69R190
Because
getBoolean("true")
evaluates for a System property called "true". oopsTypes of Changes
Checklist
CONTRIBUTING.md
documentFollowing readme
./mvnw clean package -P '!setup-test-cluster'
does not run the tests. So I don't know if a test suite will run.Further Comments
I followed quarkiverse/quarkus-rabbitmq-client#85 (comment) to fix the root cause
I check breaking change above and signed Pivotal CLA because if someone made it work via this true=true property trick well it won't work anymore as the real property name is expected.