Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology : fix connection factory property evaluation #724

Merged
merged 1 commit into from Feb 9, 2022

Conversation

laurentperez
Copy link

Proposed Changes

You can't set topology recovery using the CF configurator unless you do a trick like -Dtrue=true in JVM args

This PR is following quarkiverse/quarkus-rabbitmq-client#85 because of the root commit at e9b642f#diff-3ee7482ebddb8471bf938e29cb3b8d0704c94e0cf94fe6a67593149b99f38c69R190

Because getBoolean("true") evaluates for a System property called "true". oops

Types of Changes

  • Bugfix (non-breaking change which fixes issue #see quarkus)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Following readme ./mvnw clean package -P '!setup-test-cluster' does not run the tests. So I don't know if a test suite will run.

Further Comments

I followed quarkiverse/quarkus-rabbitmq-client#85 (comment) to fix the root cause

I check breaking change above and signed Pivotal CLA because if someone made it work via this true=true property trick well it won't work anymore as the real property name is expected.

@acogoluegnes acogoluegnes added this to the 5.14.2 milestone Feb 9, 2022
@acogoluegnes acogoluegnes merged commit 78f4512 into rabbitmq:main Feb 9, 2022
@acogoluegnes
Copy link
Contributor

Thanks!

@laurentperez laurentperez deleted the fix-cf-topology branch February 9, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants