Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host description when throwing MissedHeartbeatException #726

Merged

Conversation

laststem
Copy link
Contributor

Proposed Changes

Adding a host description when throwing MissedHeartbeatException.
if there are two RabbitMQ Node for different purposes, but exception don't showing which node it is for.
sorry for english. thank you.

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin
Copy link
Member

michaelklishin commented Mar 10, 2022

Thank you for taking the time to contribute.

I don't find this particularly useful as node logs will in practice contain relevant information. @acogoluegnes WDYT?

@acogoluegnes
Copy link
Contributor

This extra information does not make any harm, so I'm not opposed to merge this if it can help some users.

@michaelklishin michaelklishin merged commit 357226b into rabbitmq:main Mar 11, 2022
@michaelklishin
Copy link
Member

I reworded the message and backported to 5.x.

@michaelklishin michaelklishin added this to the 5.15.0 milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants