Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add <title> to all pages #135

Open
oskarrough opened this issue Oct 23, 2023 · 2 comments
Open

Add <title> to all pages #135

oskarrough opened this issue Oct 23, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@oskarrough
Copy link
Contributor

oskarrough commented Oct 23, 2023 •
edited

We currently do not update the <title> in the <head> on pages. It's always just "Radio4000" which is not ideal. It could also show the currently playing channel, if we want.

Don't know how we would handle this. As part of the router?
@oskarrough oskarrough changed the title Add <meta> titles to all pages Add <title> to all pages Oct 23, 2023
@oskarrough oskarrough added the enhancement New feature or request label Oct 30, 2023
@oskarrough
Copy link
Contributor Author

A component with that renders into head?

@oskarrough
Copy link
Contributor Author

This is how solid does it for inspiration https://docs.solidjs.com/solid-start/building-your-application/head-and-metadata. Basically a component for each "meta" element that cleans up after itself when you navigate away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
R0
Status: menu-navigation-actions
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oskarrough