Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve play buttons and the playlists they load #95

Open
oskarrough opened this issue Aug 1, 2023 · 1 comment
Open

Improve play buttons and the playlists they load #95

oskarrough opened this issue Aug 1, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@oskarrough
Copy link
Contributor

oskarrough commented Aug 1, 2023

We use <r4-play-button> in different contexts. On channels, on cards, on track page, on a track list item. Our play() method accepts channel, tracks and track.. Depending on the combination, we load a certain playlist in the player.

It doesn't feel quite right what we do at the moment. I'd like to review it and see if it can feel more natural.

Question 1

On the channel page we show a list of most recent tracks. Should playing load all tracks, or just the recent ones?

Question 2

Another example, when filtering on /tracks and you play a track, does it update the playlist to the current filter?

Related #125

@oskarrough oskarrough added enhancement New feature or request help wanted Extra attention is needed labels Aug 1, 2023
@4www 4www self-assigned this Oct 21, 2023
@oskarrough
Copy link
Contributor Author

For 1) it should load all tracks, at least that's what I would expect.

For 2) it depends. There are three ways you can play on that page:

  • "play selection" button (should set tracks to the current filtered tracks)
  • "play all" button (should reset tracks back to all)
  • "play" button on a track (should not set tracks, but keep current player.tracks. if no tracks, load all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: player-and-api
Development

No branches or pull requests

2 participants