-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Report: Exomol, hdf5 tests failing on travis (buffer error) #486
Comments
BTW do you confirm that you tested with the latest develop version? |
Yes! Only 1 test in Errorradis/test/io/test_query.py:113: radis/io/hitran.py:1424: in fetch_hitran self = <radis.io.hitran.HITRANDatabaseManager object at 0x7f43cc0c7208>
E TypeError: load() got an unexpected keyword argument 'isotope' radis/io/hitran.py:1252: TypeError Dependencies versionabsl-py==1.0.0 This indicates that the issue is definitely due to some package's version incompatibility, which can be the ones used in |
I think at least one error
is related to vaexio/vaex#2062 ; will be fixed in Vaex 4.9.2 |
@anandxkumar : still not fixed despite Vaex recent Vaex update on Travis-CI. |
Sure! I will give it a try and let you know. |
馃悰 Describe the bug
Travis failing: https://app.travis-ci.com/github/radis/radis/jobs/571532389
Steps to reproduce:
conda create -n radis_env python=3.8
and fetch latest develop branch locallypip install -e .
(pip install -e .[dev] -v didn't work)radis.json
and.radisdb
pytest
Following is the version of dependencies in the environment:
Error
platform linux -- Python 3.8.13, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/travis/build/radis/radis, configfile: setup.cfg
plugins: cov-3.0.0, asdf-2.11.1, anyio-3.6.1
collected 227 items / 16 deselected / 211 selected
radis/test/test_misc.py ...... [ 2%]
radis/test/test_phys.py .. [ 3%]
radis/test/db/test_molecule_lists.py .. [ 4%]
radis/test/db/test_molecules.py ... [ 6%]
radis/test/db/test_molparams.py . [ 6%]
radis/test/io/test_exomol.py .FF [ 8%]
radis/test/io/test_geisa.py ... [ 9%]
radis/test/io/test_hdf5.py FF [ 10%]
radis/test/io/test_hitemp.py Warning : 1 files were written but not combined. Deleting them.
['/home/travis/.radisdb/hitemp/OH-13_HITEMP2020_temp00000.hdf5']
F..Warning : 1 files were written but not combined. Deleting them.
['/home/travis/.radisdb/hitemp/OH-13_HITEMP2020_temp00000.hdf5']
Exception ignored in: <function DataFileManager.del at 0x7fcecc2eec10>
Traceback (most recent call last):
File "/home/travis/build/radis/radis/radis/api/hdf5.py", line 238, in del
self._close_temp_batch_files()
File "/home/travis/build/radis/radis/radis/api/hdf5.py", line 225, in _close_temp_batch_files
os.remove(self._temp_batch_files[i])
FileNotFoundError: [Errno 2] No such file or directory: '/home/travis/.radisdb/hitemp/OH-13_HITEMP2020_temp00000.hdf5'
FFWarning : 1 files were written but not combined. Deleting them.
['/home/travis/.radisdb/hitemp/CO2-02_02500-03000_HITEMP2010_temp00000.hdf5']
FFF [ 14%]
radis/test/io/test_hitran_cdsd.py ....... [ 17%]
radis/test/io/test_query.py ....Warning : 1 files were written but not combined. Deleting them.
['/home/travis/.radisdb/hitemp/CO-05_HITEMP2019_temp00000.hdf5']
FWarning : 1 files were written but not combined. Deleting them.
['/home/travis/build/radis/radis/radis/test/files/hitran/CO_temp00000.hdf5']
FWarning : 1 files were written but not combined. Deleting them.
['/home/travis/.radisdb/hitran/CO_temp00000.hdf5']
F [ 20%]
radis/test/lbl/test_bands.py . [ 21%]
radis/test/lbl/test_base.py .......F [ 25%]
radis/test/lbl/test_broadening.py ........FF [ 29%]
radis/test/lbl/test_calc.py .FF.FWarning : 1 files were written but not combined. Deleting them.
['/home/travis/.radisdb/hitran/CO2_temp00000.hdf5']
FWarning : 1 files were written but not combined. Deleting them.
['/home/travis/.radisdb/hitran/CO_temp00000.hdf5']
F.F. [ 34%]
radis/test/lbl/test_database.py .. [ 35%]
radis/test/lbl/test_factory.py ................ [ 43%]
radis/test/lbl/test_labels.py . [ 43%]
radis/test/lbl/test_loader.py .... [ 45%]
radis/test/lbl/test_overp.py . [ 45%]
radis/test/lbl/test_spectrum.py .... [ 47%]
radis/test/levels/test_partfunc.py ............. [ 54%]
radis/test/los/test_slabs.py .... [ 55%]
radis/test/misc/test_arrays.py ............. [ 62%]
radis/test/misc/test_basics.py ... [ 63%]
radis/test/misc/test_config.py .. [ 64%]
radis/test/misc/test_utils.py .. [ 65%]
radis/test/phys/test_blackbody.py ... [ 66%]
radis/test/phys/test_dunham.py .. [ 67%]
radis/test/phys/test_units.py . [ 68%]
radis/test/spectrum/test_compare.py .FF [ 69%]
radis/test/spectrum/test_operations.py ............ [ 75%]
radis/test/spectrum/test_rescale.py ........ [ 79%]
radis/test/spectrum/test_spectrum.py ............... [ 86%]
radis/test/spectrum/test_utils.py .. [ 87%]
radis/test/tools/test_database.py ....F [ 89%]
radis/test/tools/test_gascomp.py . [ 90%]
radis/test/tools/test_line_survey.py .. [ 90%]
radis/test/tools/test_slit.py ........... [ 96%]
radis/test/tools/test_track_ref.py .FWarning : 1 files were written but not combined. Deleting them.
['/home/travis/.radisdb/hitran/CO_temp00000.hdf5']
FWarning : 1 files were written but not combined. Deleting them.
['/home/travis/.radisdb/hitran/CO_temp00000.hdf5']
FF [ 98%]
radis/test/validation/test_CO2_3Tvib_vs_klarenaar.py . [ 99%]
radis/test/validation/test_RADIS_vs_HAPI_line_broadening.py F [ 99%]
radis/test/validation/test_validation_vs_specair_noneqCO.py . [100%]Warning : 1 files were written but not combined. Deleting them.
['/home/travis/.radisdb/hitran/CO2_temp00000.hdf5']
=================================== FAILURES ===================================
__________________________ test_calc_exomol_spectrum ___________________________
verbose = True, plot = True, args = (), kwargs = {}
calc_spectrum = <function calc_spectrum at 0x7fcec4b66b80>
@pytest.mark.needs_connection
def test_calc_exomol_spectrum(verbose=True, plot=True, *args, **kwargs):
"""Auto-fetch and calculate a SiO spectrum from the ExoMol database
radis/test/io/test_exomol.py:55:
radis/lbl/calc.py:514: in calc_spectrum
generated_spectrum = _calc_spectrum_one_molecule(
radis/lbl/calc.py:753: in _calc_spectrum_one_molecule
sf.fetch_databank(**conditions)
radis/lbl/loader.py:1302: in fetch_databank
df, local_path, Z_exomol = fetch_exomol(
radis/io/exomol.py:202: in fetch_exomol
mdb = MdbExomol(
radis/api/exomolapi.py:1104: in init
mgr.write(mgr.cache_file(self.states_file), states)
radis/api/hdf5.py:192: in write
df.export_hdf5(file, group=key, mode="w")
../../../micromamba/envs/radis-env/lib/python3.8/site-packages/vaex/dataframe.py:6912: in export_hdf5
writer.write(
../../../micromamba/envs/radis-env/lib/python3.8/site-packages/vaex/hdf5/writer.py:42: in exit
self.close()
self = <vaex.hdf5.writer.Writer object at 0x7fcec09fcc40>
def close(self):
if self.mmap is not None:
E BufferError: cannot close exported pointers exist
../../../micromamba/envs/radis-env/lib/python3.8/site-packages/vaex/hdf5/writer.py:34: BufferError
----------------------------- Captured stdout call -----------------------------
Background atmosphere: Air
Downloading http://www.exomol.com/db/SiO/28Si-16O/EBJT/28Si-16O__EBJT.def
Downloading http://www.exomol.com/db/SiO/28Si-16O/EBJT/28Si-16O__EBJT.pf
Downloading http://www.exomol.com/db/SiO/28Si-16O/EBJT/28Si-16O__EBJT.states.bz2
Downloading http://www.exomol.com/db/SiO/28Si-16O/28Si-16O__H2.broad
Error: Couldn't download .broad file at http://www.exomol.com/db/SiO/28Si-16O/28Si-16O__H2.broad and save.
Downloading http://www.exomol.com/db/SiO/28Si-16O/28Si-16O__He.broad
Error: Couldn't download .broad file at http://www.exomol.com/db/SiO/28Si-16O/28Si-16O__He.broad and save.
Downloading http://www.exomol.com/db/SiO/28Si-16O/28Si-16O__air.broad
Error: Couldn't download .broad file at http://www.exomol.com/db/SiO/28Si-16O/28Si-16O__air.broad and save.
Note: Caching states data to the vaex format. After the second time, it will become much faster.
馃挕 Possible solutions
Error is possibly occurring when fetching data from hitran, hitemp, and merging the temporary data files causing buffer issues. The issue might lie in the
hdf5.py
file which is responsible for downloading and merging the data lines.Also, a thing to note is that the issue is not reproducible on
radis-lab
so it may be a dependency version specific issue, some compatibility issue between vaex or other packages.馃幉 Radis version
'0.13.0'
馃捇 Operating system
Linux
The text was updated successfully, but these errors were encountered: