-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摎 API : make sure the API remains Exojax compatible #597
Comments
This is a bit difficult problem but important for long time development. Writing some test code for api.py in ExoJAX, and importing these tests to radis? In general, writing the unit tests for database I/O is a bit challenging because it sometimes needs to be downloaded from the database websites. |
Yes. Do you already have some unitests in Exojax/api? I can borrow them and add them in Radis.api to ensure backward compatibility |
back to this issue. See exojax #462 |
We do 2 things :
from radis.test.utils import getTestFile
from radis import load_spec
load_spec(getTestFile('CO_Tgas1500K_mole_fraction0.01.spec')) These are very small files, shipped with Radis, usually used to ensure I/O compatibility |
Thanks. It looks there is no ExoMol fragment file available in radis.test.utils.getTestFile. Then, I will use a fragment ExoMol file in exojax. |
馃挱 Description
Since #480 Radis embeds a common API shared by Radis-Line-by-line (spectrum calculation code) and Exojax
We should add tests in the Radis CI to make sure the API always remains fully compatible with Exojax functions (in terms of signature, i.e. input parmaters ).
I see it as :
@HajimeKawahara @YuiKasagi any idea / request on this ?
The text was updated successfully, but these errors were encountered: