s.units['waverange'] and s.conditions['waveunit'] are duplicate

[dcmvdbekerom]

🐛 Describe the bug

E: the issue is broader than just the duplication of the waveunits. Units are checked and passed by a number of functions, which is not an ideal situation imho.

I would suggest to have keep one storage for the canonical units (could be s.units), which may only be modified by a setter which performs sanity checks and conversions during setting. All other functions read from this place, and do not explicitly require units to be passes as arguments (at least for all spectrum methods).

Old post:
We have two attributes that describe the waveunit.
We should get rid of one of them to prevent confusion.

💡 Possible solutions

Pro's to keep s.conditions['waveunit']:

• it's used almost exclusively already
• It's in a place where the user is likely to find it

Pro's to keep s.units['waverange']:

• it would be weird if it wasn't represented in s.units
• it's in a place that makes sense

My preference would be to keep s.units['waverange']

🎲 Radis version

0.14

💻 Operating system

Windows