Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Colorful to Rich #459

Closed
wants to merge 43 commits into from
Closed

Migrate from Colorful to Rich #459

wants to merge 43 commits into from

Conversation

inquisitev
Copy link
Contributor

@inquisitev inquisitev commented Oct 8, 2023 •
edited

Migrating from colorful to rich

This will break every integration test. Its looking good so far, but the tables are disappearing on the 'after step' hook update to the console output.

current known issues:

  • table parmeters are not updating live
  • table disappears in the after stage

todo:

  • replace all output with current output so integration tests pass

closes #439

@fliiiix
Copy link
Member

fliiiix commented Oct 8, 2023

The trick to update all integration test is by patching the test here https://github.com/radish-bdd/radish/blob/main/tests/integration/test_main.py#L357 and just write the actual_output to the expected file and remove the asserts and then run tox once on linux and windows to generate all the files

we need to inspected a bunch of tests by hand an check the diffs anyway to make sure we do not break anything with this change

@inquisitev inquisitev marked this pull request as ready for review October 11, 2023 22:47
@inquisitev
Copy link
Contributor Author

I think im still seeing some inconsistent word wrapping happening with this new library, hence why my tests pass locally but fail in CI

@codecov
Copy link

codecov bot commented Oct 21, 2023 •
edited

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (4688b59) 87.26% compared to head (da22962) 86.81%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   87.26%   86.81%   -0.46%     
==========================================
  Files          39       41       +2     
  Lines        2380     2442      +62     
==========================================
+ Hits         2077     2120      +43     
- Misses        303      322      +19
Flag Coverage Δ
unittests 86.81% <73.88%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
radish/extensions/formatters/dots.py 95.12% <100.00%> (ø)
radish/testing/__main__.py 0.00% <ø> (ø)
radish/utils.py 69.38% <100.00%> (ø)
radish/extensions/endreport_writer.py 88.77% <94.11%> (+0.11%) ⬆️
radish/main.py 77.38% <66.66%> (-1.03%) ⬇️
radish/errororacle.py 71.05% <60.00%> (ø)
radish/extensions/formatters/gherkin.py 95.90% <91.66%> (-0.03%) ⬇️
radish/printer.py 86.79% <86.79%> (ø)
radish/test.py 0.00% <0.00%> (ø)
radish/testing/matches.py 64.53% <41.93%> (+0.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inquisitev
Copy link
Contributor Author

Closing for #465

@inquisitev inquisitev closed this Oct 22, 2023
@inquisitev inquisitev deleted the colorful-to-rich2 branch November 4, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
radish drop legacy (Debian Stretch)
Development

Successfully merging this pull request may close these issues.

Switch from colorful to rich
2 participants
@inquisitev @fliiiix