Tabs are triggered with right mouse click

[badsyntax]

Hi there.

I've noticed the tabs are triggered using the right mouse click. This behaviour can be observed here: https://www.radix-ui.com/docs/primitives/components/tabs (Chrome, MacOS)

It seems this behaviour is not intentional, see comment here:

primitives/packages/react/tabs/src/Tabs.tsx

Lines 177 to 183 in 2fbc347

	onMouseDown={composeEventHandlers(props.onMouseDown, (event) => {
	// only call handler if it's the left button (mousedown gets triggered by all mouse buttons)
	// but not when the control key is pressed (avoiding MacOS right click)
	if (!disabled && event.button === 0 && event.ctrlKey === false) {
	context.onValueChange(value);
	}
	})}

I believe the right-mouse-click is triggered via the focus event here:

primitives/packages/react/tabs/src/Tabs.tsx

Lines 187 to 194 in 2fbc347

	onFocus={composeEventHandlers(props.onFocus, () => {
	// handle "automatic" activation if necessary
	// ie. activate tab following focus
	const isAutomaticActivation = context.activationMode !== 'manual';
	if (!isSelected && !disabled && isAutomaticActivation) {
	context.onValueChange(value);
	}
	})}

Possibly related tabs focus issue: #1047

Let me know if you'd prefer for me to create an issue for this.

[benoitgrelard]

Hey @badsyntax, nice seeing you here! 🙂
Yeah you're totally right about that one, I've converted into an issue and will address now.

Cheers!