-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature(Nuxt): Add radix-vue
and other main deps as dependencies
#529
Comments
I like the idea, but we should release |
I think releasing a new version won't be necessary for those deps as long as you keep the |
Nice TIL |
Can you elaborate on the module you linked? Do you want to add it as a dependency too? I see it has a lot of modules that are needed by the module such as tailwindcss and colormode. I'm not sure if it's a good idea though |
I think that link is got the same idea as yours I just share it, thought it might be helpful |
Oh I got it wrong then 馃槄 Yeah it's similar to it. Also similar to |
@MuhammadM1998 one question, what is if I want to use import { type VariantProps } from 'class-variance-authority' I should install it again (in devDependencies) even though |
@sadeghbarati You don't need to add it again that import would just work. Actually 'class-variance-authority' has So this "dependencies": {
"class-variance-authority": "^0.7.0",
"clsx": "^2.1.1",
}, Can be simplified to this if the clsx (which is currently 2.0.0) version in cva's suits your needs "dependencies": {
"class-variance-authority": "^0.7.0",
} and the following import would still work import { type ClassValue, clsx } from 'clsx' If you want to use a different version than the one in cva's dependencies. You'd specify it as in "dependencies": {
"class-variance-authority": "^0.7.0",
},
"pnpm": {
"overrides": {
"clsx": "^3" // This would get installed instead of `2.0.0` specified by 'class-variance-authority'
}
} |
radix-vue
and other main deps as dependencies
in nuxt moduleradix-vue
and other main deps as dependencies
Describe the feature
Hey 馃憢
There are primary dependencies that shadcn-vue relies on and automatically installed by the CLI
I think adding them as
dependencies
to the nuxt module makes sense. They would get installed with the module without cluttering thepackage.json
. Similar to other nuxt modules which follows the pattern of a 'one-click-setup'.I've created a branch locally and it works as expected. Happy to make a PR if this is accepted.
Additional information
The text was updated successfully, but these errors were encountered: