Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-router packages and refactor related components #1576

Closed
5 of 11 tasks
jorgegonzalez opened this issue Jan 26, 2022 · 0 comments · Fixed by #1506
Closed
5 of 11 tasks

Upgrade react-router packages and refactor related components #1576

jorgegonzalez opened this issue Jan 26, 2022 · 0 comments · Fixed by #1506
Assignees
Labels
dependencies Pull requests that update a dependency file dev frontend

Comments

@jorgegonzalez
Copy link

jorgegonzalez commented Jan 26, 2022

Description:

This dependabot PR was opened with an upgrade for react-router-dom, however react-router and react-router-dom need to be upgraded in parallel. These upgrades include breaking changes, and are incompatible with any version of connected-react-router, so that package must be replaced with an alternative, redux-react-router.

supasate/connected-react-router#543

Acceptance Criteria:
Create a list of functional outcomes that must be achieved to complete this issue

  • react-router and react-router-dom are upgraded to latest major version
  • package.json is updated
  • package-lock.json is updated
  • All existing behavior and application functionality should remain identical
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:
Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

  • Upgrade react-router, react-router-dom with npm
  • Refactor usages of react-router and react-router-dom
  • Replace connected-react-router with redux-react-router
  • Refactor all relevant tests (probably the failing ones)
  • Run Testing Checklist and confirm all tests pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file dev frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant