Migrate from Apollo codegen to graphql-code-generator #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 68.34% 68.35%
=======================================
Files 104 104
Lines 4041 4042 +1
Branches 890 888 -2
=======================================
+ Hits 2762 2763 +1
Misses 1194 1194
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mipyykko
force-pushed
the
refactor-apollo-codegen-to-graphql-codegen
branch
from
03f8e71
to
693ef36
Compare
mipyykko
force-pushed
the
refactor-apollo-codegen-to-graphql-codegen
branch
from
693ef36
to
c432927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've created the frontend types with Apollo's own CLI since the beginning, but as it's become increasingly flaky because mismatching dependencies and all, it's better to migrate away from it. Apollo is advocating its new Rover CLI, which does not include the codegen and the developers there seem to be recommending
graphql-code-generatoras codegen replacement anyway.This PR does introduce changes in a lot of files, but most of them are just changing the imports to point at the new generated types and updating the GraphQL operations accordingly. The new generated code also removes a lot of redundant manual query typing, which is nice.
The GraphQL operation and fragment definitions are now all in
frontend/graphql/*as.graphqlfiles instead of Typescript files exportinggqlvariables. Storing the definitions next to where the operations are actually used might also be a viable alternative, as would be organizing the query/mutation/fragment combinations by usage.The generated code now resides in
frontend/graphql/generated.graphql-code-generatordoes advocate generating the code alongside their definitions, but personally I like them all being in one place.Also included some new documentation on the dev workflow with GraphQL.