Skip to content
This repository has been archived by the owner on May 4, 2020. It is now read-only.

Elements of AI app fails to load certification status #4

Open
m4rku55 opened this issue Jun 29, 2018 · 2 comments
Open

Elements of AI app fails to load certification status #4

m4rku55 opened this issue Jun 29, 2018 · 2 comments

Comments

@m4rku55
Copy link

m4rku55 commented Jun 29, 2018

router.post('/state/:courseid',

Is the /state/elements-of-ai endpoint working as intended? When I checked the request using developer toolbar, the body of response is empty which consequently crashes the parsing of request. The corresponding fix to client is here: https://github.com/rage/elements-of-ai-material/compare/features/course-state-fix?expand=1

Why the request is POST instead of GET if the endpoint is used for fetching the data from server? POST request should be used only when creating a new resource and when the id is not known: http://restcookbook.com/HTTP%20Methods/put-vs-post/

@tulir @mipyykko @nygrenh

@m4rku55
Copy link
Author

m4rku55 commented Jun 29, 2018

According to Slack discussion nothing (null?) is returned if state doesn't exist, so it's working as intended

@m4rku55
Copy link
Author

m4rku55 commented Jul 2, 2018

Empty response is returned if progress is 0% (no questions answered)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant