Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp: getting channel with biggest capacity is insecure if no tokens exist #2145

Open
weilbith opened this issue Sep 21, 2020 · 0 comments
Open

Comments

@weilbith
Copy link
Contributor

This is a more of a theoretic issue, but super simple to fix.

Steps to Reproduce

  1. Attempt to get the channel with the biggest capacity for a token that is not used
  2. Checkout the error message of the store its getter function

Expected Result

  • Return something like null (like in other getters)

Actual Result

  • Throws
@andrevmatos andrevmatos changed the title dApp: getting channel with biggestes capcity is unsecure of no tokens exist dApp: getting channel with biggest capacity is insecure of no tokens exist Sep 23, 2020
@taleldayekh taleldayekh changed the title dApp: getting channel with biggest capacity is insecure of no tokens exist dApp: getting channel with biggest capacity is insecure if no tokens exist Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants