Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Testing: Verify partial doubles #906

Open
carpodaster opened this issue Jan 5, 2018 · 5 comments
Open

Testing: Verify partial doubles #906

carpodaster opened this issue Jan 5, 2018 · 5 comments

Comments

@carpodaster
Copy link
Member

carpodaster commented Jan 5, 2018

Working on #905 revealed that we stub methods on objects that originally do not respond to these methods – and that's a trap! We can set verify_partial_doubles to true in spec/spec_helper.rb but that will break tests. These tests will have to be fixed.

Why is this important? See this example in the RSpec docs.

@swdonovan
Copy link

swdonovan commented Jan 8, 2018

Hi there! I’m a first-time contributor and was hoping to help out with this issue.@dphilla & I noticed nobody was assigned to it, but if there’s already a solution in progress we're happy to try helping out elsewhere. Thanks!

@emcoding
Copy link
Member

emcoding commented Jan 8, 2018

Hi @swdonovan and @dphilla ! Welcome! Great that you want to contribute.
This issue is available, so, sure, give it a go!

Let us know if you get stuck. We are here to help!

@emcoding
Copy link
Member

Hey @swdonovan and @dphilla. How is this PR going? Are you working on it? Can we help?

@ArushiSinghal
Copy link
Contributor

Hello
If the task is still not complete, I want to contribute to this task.

@theomelo
Copy link

@F3PiX @carpodaster is this fixed somehow? I would like to help if not, seems like a long time since the issue got an update

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants