Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to replace check for WEBPACK_DEV_SERVER to WEBPACK_DEV_SERVE when going to webpack-dev-server v4 #3057

Closed
justin808 opened this issue Jun 17, 2021 · 2 comments

Comments

@justin808
Copy link
Contributor

Reminder for a future upgrade of the webpack-dev-server

process.env.WEBPACK_DEV_SERVER renamed to process.env.WEBPACK_DEV_SERVE in PR 3000 for v4 off webpack-dev-server.

Details

Older code:

https://github.com/webpack/webpack-dev-server/blob/7ee869e17fc3c0db56c8ff44dc1c6b6f03c85c1a/lib/Server.js#L65-L68

Originally added: webpack/webpack-dev-server#1929

Newer, on master:

https://github.com/webpack/webpack-dev-server/blob/master/lib/Server.js#L19-L21

@nertzy
Copy link

nertzy commented Aug 23, 2021

To help with future searches, it's actually process.env.WEBPACK_SERVE (no _DEV_)

@dhh
Copy link
Member

dhh commented Aug 25, 2021

This has been fixed in 6.0.0.rc.4.

@dhh dhh closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants