package.json

@@ -1,6 +1,6 @@
 {
   "name": "npm-check-updates",
-  "version": "16.3.20",
+  "version": "16.3.21",
   "author": "Tomas Junnonen <tomas1@gmail.com>",
   "license": "Apache-2.0",
   "contributors": [

src/index.ts

@@ -205,6 +205,10 @@ export async function run(
   async function runUpgrades(): Promise<Index<string> | PackageFile | void> {
     const defaultPackageFilename = getPackageFileName(options)
 
+    // Workspace package names
+    // These will be used to filter out local workspace packages so they are not fetched from the registry.
+    let workspacePackages: string[] = []
+
     // Find the package file with globby.
     // When in workspaces mode, only include the root project package file when --root is used.
     let pkgs =
@@ -248,20 +252,26 @@ export async function run(
           .replace(/\\/g, '/'),
       )
 
-      const workspacePackages = [
+      // e.g. [packages/a/package.json, ...]
+      const workspacePackageFiles = [
         ...globby.sync(workspacePackageGlob, {
           ignore: ['**/node_modules/**'],
         }),
       ]
 
+      // Extract the package names from the full package paths.
+      // These will be used to filter out local workspace packages so they are not fetched from the registry.
+      // e.g. [a, b, c, ...]
+      workspacePackages = workspacePackageFiles.map(file => file.split('/').slice(-2)[0])
+
       // add workspace packages
       pkgs = [
         ...pkgs,
         ...(options.workspaces
           ? // --workspaces
-            workspacePackages
+            workspacePackageFiles
           : // --workspace
-            workspacePackages.filter(pkgFile =>
+            workspacePackageFiles.filter(pkgFile =>
               options.workspace?.some(workspace =>
                 workspaces?.some(
                   workspacePattern =>
@@ -291,10 +301,11 @@ export async function run(
           // Merge config options.
           rcConfig = mergeOptions(options, rcConfig)
         }
-        const pkgOptions = {
+        const pkgOptions: Options = {
           ...options,
           ...rcConfig,
           packageFile,
+          workspacePackages,
         }
         const [pkgData, pkgFile] = await findPackage(pkgOptions)
         return {

src/lib/getCurrentDependencies.ts

@@ -5,6 +5,7 @@ import { PackageFile } from '../types/PackageFile'
 import { VersionSpec } from '../types/VersionSpec'
 import filterAndReject from './filterAndReject'
 import filterObject from './filterObject'
+import { keyValueBy } from './keyValueBy'
 
 /** Returns true if spec1 is greater than spec2, ignoring invalid version ranges. */
 const isGreaterThanSafe = (spec1: VersionSpec, spec2: VersionSpec) =>
@@ -45,8 +46,9 @@ function getCurrentDependencies(pkgData: PackageFile = {}, options: Options = {}
   }, {} as Index<VersionSpec>)
 
   // filter & reject dependencies and versions
+  const workspacePackageMap = keyValueBy(options.workspacePackages || [])
   const filteredDependencies = filterObject(
-    allDependencies,
+    filterObject(allDependencies, name => !workspacePackageMap[name]),
     filterAndReject(
       options.filter || null,
       options.reject || null,

src/lib/keyValueBy.ts

@@ -4,6 +4,7 @@ type KeyValueGenerator<K, V, R> = (key: K, value: V, accum: Index<R>) => Index<R
 type ArrayKeyValueGenerator<T, R> = KeyValueGenerator<T, number, R>
 type ObjectKeyValueGenerator<T, R> = KeyValueGenerator<string, T, R>
 
+export function keyValueBy<T>(arr: T[]): Index<true>
 export function keyValueBy<T, R>(arr: T[], keyValue: KeyValueGenerator<T, number, R>, initialValue?: Index<R>): Index<R>
 export function keyValueBy<T, R>(
   obj: Index<T>,
@@ -12,12 +13,14 @@ export function keyValueBy<T, R>(
 ): Index<R>
 
 /** Generates an object from an array or object. Simpler than reduce or _.transform. The KeyValueGenerator passes (key, value) if the input is an object, and (value, i) if it is an array. The return object from each iteration is merged into the accumulated object. Return null to skip an item. */
-export function keyValueBy<T, R>(
+export function keyValueBy<T, R = true>(
   input: T[] | Index<T>,
-  keyValue: ArrayKeyValueGenerator<T, R> | ObjectKeyValueGenerator<T, R>,
+  // if no keyValue is given, sets all values to true
+  keyValue?: ArrayKeyValueGenerator<T, R> | ObjectKeyValueGenerator<T, R>,
   accum: Index<R> = {},
 ): Index<R> {
   const isArray = Array.isArray(input)
+  keyValue = keyValue || ((key: T) => ({ [key as unknown as string]: true as unknown as R }))
   // considerably faster than Array.prototype.reduce
   Object.entries(input || {}).forEach(([key, value], i) => {
     const o = isArray

src/types/Options.ts

@@ -14,4 +14,7 @@ export type Options = RunOptions & {
   packageData?: string
   peerDependencies?: Index<any>
   rcConfigPath?: string
+  // A list of local workspace packages by name.
+  // This is used to ignore local workspace packages when fetching new versions.
+  workspacePackages?: string[]
 }

test/workspaces.test.ts

@@ -58,6 +58,38 @@ const setup = async (workspaces: string[] | { packages: string[] } = ['packages/
   return tempDir
 }
 
+/** Sets up a workspace with a dependency to a symlinked workspace package. */
+const setupSymlinkedPackages = async (workspaces: string[] | { packages: string[] } = ['packages/**']) => {
+  const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'npm-check-updates-'))
+  await fs.mkdtemp(path.join(os.tmpdir(), 'npm-check-updates-'))
+
+  const pkgDataRoot = JSON.stringify({ workspaces })
+
+  const pkgDataA = JSON.stringify({
+    dependencies: {
+      b: '0.4.2',
+      'ncu-test-v2': '1.0.0',
+    },
+  })
+
+  const pkgDataB = JSON.stringify({
+    dependencies: {
+      'ncu-test-v2': '1.1.0',
+    },
+  })
+
+  // write root package file
+  await fs.writeFile(path.join(tempDir, 'package.json'), pkgDataRoot, 'utf-8')
+
+  // write workspace package files
+  await fs.mkdir(path.join(tempDir, 'packages/a'), { recursive: true })
+  await fs.writeFile(path.join(tempDir, 'packages/a/package.json'), pkgDataA, 'utf-8')
+  await fs.mkdir(path.join(tempDir, 'packages/b'), { recursive: true })
+  await fs.writeFile(path.join(tempDir, 'packages/b/package.json'), pkgDataB, 'utf-8')
+
+  return tempDir
+}
+
 describe('--workspaces', function () {
   this.timeout(60000)
 
@@ -147,6 +179,24 @@ describe('--workspaces', function () {
       await fs.rm(tempDir, { recursive: true, force: true })
     }
   })
+
+  // https://github.com/raineorshine/npm-check-updates/issues/1217
+  it('ignore local workspace packages', async () => {
+    const tempDir = await setupSymlinkedPackages()
+    try {
+      const upgrades = await spawn('node', [bin, '--jsonUpgraded', '--workspaces'], { cwd: tempDir }).then(JSON.parse)
+      upgrades.should.deep.equal({
+        'packages/a/package.json': {
+          'ncu-test-v2': '2.0.0',
+        },
+        'packages/b/package.json': {
+          'ncu-test-v2': '2.0.0',
+        },
+      })
+    } finally {
+      await fs.rm(tempDir, { recursive: true, force: true })
+    }
+  })
 })
 
 describe('--workspace', function () {