Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add repo link to update notifer #1193

Closed
shrpne opened this issue Sep 21, 2022 · 4 comments
Closed

Feature request: add repo link to update notifer #1193

shrpne opened this issue Sep 21, 2022 · 4 comments

Comments

@shrpne
Copy link

shrpne commented Sep 21, 2022

It would be useful to add repository or changelog link to the notification generated by update-notifier

It can be done with custom message option as described here yeoman/update-notifier#213 (comment)

@raineorshine
Copy link
Owner

Hi, thanks for the suggestion.

Given that I only add change log notes for major version releases, I think I would prefer without the link. If there was a way to provide a direct link to the release notes only when they exist, I would be open to that.

@shrpne
Copy link
Author

shrpne commented Sep 21, 2022

May be just the link for the repository then? So user can investigate what is changed

@raineorshine
Copy link
Owner

I have given this further consideration, and figured out a way to provide useful information for both major and non-major upgrades without having to change my changelog policy.

Major updates link to the release notes:

╭────────────────────────────────────────────────────────────────────────────╮
│                                                                            │
│                      Update available 15.3.4 → 16.0.0                      │
│                  Run npm i -g npm-check-updates to update                  │
│   https://github.com/raineorshine/npm-check-updates/releases/tag/v16.0.0   │
│                                                                            │
╰────────────────────────────────────────────────────────────────────────────╯

Major updates across multiple major versions link to each major version's release notes:

╭────────────────────────────────────────────────────────────────────────────╮
│                                                                            │
│                      Update available 13.0.0 → 16.3.1                      │
│                  Run npm i -g npm-check-updates to update                  │
│   https://github.com/raineorshine/npm-check-updates/releases/tag/v14.0.0   │
│   https://github.com/raineorshine/npm-check-updates/releases/tag/v15.0.0   │
│   https://github.com/raineorshine/npm-check-updates/releases/tag/v16.0.0   │
│                                                                            │
╰────────────────────────────────────────────────────────────────────────────╯

Non-major updates link to a list of commits between current and latest:

╭─────────────────────────────────────────────────────────────────────────────────╮
│                                                                                 │
│                        Update available 16.2.0 → 16.3.1                         │
│                    Run npm i -g npm-check-updates to update                     │
│   https://github.com/raineorshine/npm-check-updates/compare/v16.2.0...v16.3.1   │
│                                                                                 │
╰─────────────────────────────────────────────────────────────────────────────────╯

Published in v16.3.2

@shrpne
Copy link
Author

shrpne commented Sep 23, 2022

Cool! Thank you!

@shrpne shrpne closed this as completed Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants