Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 19.8.0 broke ncu #1279

Closed
3 tasks done
nassau-t opened this issue Mar 14, 2023 · 7 comments
Closed
3 tasks done

node 19.8.0 broke ncu #1279

nassau-t opened this issue Mar 14, 2023 · 7 comments

Comments

@nassau-t
Copy link

nassau-t commented Mar 14, 2023

  • I have searched for similar issues
  • I am using the latest version of npm-check-updates
  • I am using node >= 14.14

Steps to Reproduce

.ncurc:

Dependencies:

Steps:

Current Behavior

tested on windows 10

node -v
v19.8.0

ncu -g
C:\Windows\system32\cmd.exe - "node" "c:\npm_repository\node_modules\npm-check-updates\build\src\bin\cli.js" -g[9576]: c:\ws\src\module_wrap.cc:599: Assertion `(it) != (env->id_to_function_map.end())' failed.
1: 00007FF6364B22FF node_api_throw_syntax_error+180191
2: 00007FF6364369D6 v8::internal::MicrotaskQueue::GetMicrotasksScopeDepth+61942
3: 00007FF636436DB2 v8::internal::MicrotaskQueue::GetMicrotasksScopeDepth+62930
4: 00007FF636477520 v8::internal::ReusableUnoptimizedCompileState::ast_raw_string_zone+9696
5: 00007FF636E353AD v8::internal::Isolate::RunHostImportModuleDynamicallyCallback+605
6: 00007FF636A9AFD4 v8::internal::Runtime::SetObjectProperty+2548
7: 00007FF63701FC0C v8::internal::SetupIsolateDelegate::SetupHeap+607212
8: 00007FF6370CD0A5 v8::internal::SetupIsolateDelegate::SetupHeap+1316997
9: 00007FF636F97330 v8::internal::SetupIsolateDelegate::SetupHeap+47888
10: 00007FF636F97330 v8::internal::SetupIsolateDelegate::SetupHeap+47888
11: 00007FF636FCEE58 v8::internal::SetupIsolateDelegate::SetupHeap+276024
12: 00007FF637078985 v8::internal::SetupIsolateDelegate::SetupHeap+971109
13: 00007FF636FBECE0 v8::internal::SetupIsolateDelegate::SetupHeap+210112
14: 00007FF636F959AB v8::internal::SetupIsolateDelegate::SetupHeap+41355
15: 00007FF636E45CA0 v8::internal::Execution::CallWasm+1664
16: 00007FF636E45DBB v8::internal::Execution::CallWasm+1947
17: 00007FF636E46B6A v8::internal::Execution::TryCallScript+346
18: 00007FF636E1E6E2 v8::internal::MicrotaskQueue::RunMicrotasks+370
19: 00007FF636E1E4AA v8::internal::MicrotaskQueue::PerformCheckpointInternal+74
20: 00007FF6364E680E node::CallbackScope::~CallbackScope+414
21: 00007FF6364E66DE node::CallbackScope::~CallbackScope+110
22: 00007FF63641F38E v8::base::CPU::has_fpu+38062
23: 00007FF636431775 v8::internal::MicrotaskQueue::GetMicrotasksScopeDepth+40853
24: 00007FF6365179E7 uv_timer_stop+1207
25: 00007FF636513E5B uv_update_time+491
26: 00007FF6365139A2 uv_run+1266
27: 00007FF6364E5F95 node::SpinEventLoop+389
28: 00007FF6363ED3C8 cppgc::internal::Marker::conservative_visitor+51768
29: 00007FF636472A4E node::InitializeOncePerProcess+2990
30: 00007FF636474D0E node::Start+3566
31: 00007FF636473F50 node::Start+48
32: 00007FF63627E44C AES_cbc_encrypt+150140
33: 00007FF6375E13D4 inflateValidate+19028
34: 00007FFC20B07614 BaseThreadInitThunk+20
35: 00007FFC22AA26A1 RtlUserThreadStart+33

ncu (not global), same error.

Expected Behavior

It should work.

@hzz888
Copy link

hzz888 commented Mar 15, 2023

Same issue on macOS, ncu fails to run after upgrading to node 19.8.0

@hzz888
Copy link

hzz888 commented Mar 15, 2023

Error message:

node[20078]: ../src/module_wrap.cc:599:MaybeLocal<v8::Promise> node::loader::ImportModuleDynamically(Local<v8::Context>, Local<v8::Data>, Local<v8::Value>, Local<v8::String>, Local<v8::FixedArray>): Assertion `(it) != (env->id_to_function_map.end())' failed.
 1: 0x108c798fc node::Abort() [/usr/local/Cellar/node/19.8.0/bin/node]
 2: 0x108c798e7 node::Abort() [/usr/local/Cellar/node/19.8.0/bin/node]
 3: 0x108c3b7c5 node::loader::ImportModuleDynamically(v8::Local<v8::Context>, v8::Local<v8::Data>, v8::Local<v8::Value>, v8::Local<v8::String>, v8::Local<v8::FixedArray>) [/usr/local/Cellar/node/19.8.0/bin/node]
 4: 0x108f0407b v8::internal::Isolate::RunHostImportModuleDynamicallyCallback(v8::internal::MaybeHandle<v8::internal::Script>, v8::internal::Handle<v8::internal::Object>, v8::internal::MaybeHandle<v8::internal::Object>) [/usr/local/Cellar/node/19.8.0/bin/node]
 5: 0x109277acf v8::internal::Runtime_DynamicImportCall(int, unsigned long*, v8::internal::Isolate*) [/usr/local/Cellar/node/19.8.0/bin/node]
 6: 0x108aba334 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvInRegister_NoBuiltinExit [/usr/local/Cellar/node/19.8.0/bin/node]
[1]    20078 abort      ncu -g

@kohanajs
Copy link

Same here for node 19.8.0 on windows. I downgraded node to 19.7.0 the ncu works again.

@nassau-t
Copy link
Author

It's a node v19.8.0 confirmed bug
nodejs/node#47096

@kamui545
Copy link

It seems to be fixed on Node 19.8.1

@hzz888
Copy link

hzz888 commented Mar 16, 2023

Node 19.8.1 had fixed this on mac.

@nassau-t
Copy link
Author

Yes, node v19.8.1 has solved this, so I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants