Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm ci fails on Windows #1343

Open
Zamiell opened this issue Nov 3, 2023 · 1 comment
Open

npm ci fails on Windows #1343

Zamiell opened this issue Nov 3, 2023 · 1 comment
Labels

Comments

@Zamiell
Copy link
Contributor

Zamiell commented Nov 3, 2023

See #1237 (comment)

@raineorshine
Copy link
Owner

raineorshine commented Nov 3, 2023

Thanks for reporting.

What you're seeing is actually a bug rather than an intention to make bun required. As you can see in the comments, the script is supposed to succeed on Windows and not use bun in that case.

Always return success, even if the install script fails.
Windows is expected to fail and the bun tests will be skipped.

0c25e3a#diff-5d5f97aca37e5bc4dec159fe505cafcaadd3f7c801c86e0926e093e17b52d327R3

I'm not on a Windows machine, but if someone on Windows could identify what is wrong in that script that would be super helpful.

@raineorshine raineorshine changed the title Don't use Bun Skip bun setup on Windows Nov 3, 2023
@Zamiell Zamiell changed the title Skip bun setup on Windows npm ci fails on Windows Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants