Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --format group,repo the default #1379

Open
3 tasks done
wmertens opened this issue Mar 15, 2024 · 3 comments
Open
3 tasks done

Make --format group,repo the default #1379

wmertens opened this issue Mar 15, 2024 · 3 comments

Comments

@wmertens
Copy link
Contributor

  • I have searched for similar issues
  • I am using the latest version of npm-check-updates
  • I am using node >= 14.14

IMHO it's much more user friendly to show repo links and group by update type by default.

@raineorshine
Copy link
Owner

Thank you for the suggestion. I've thought about making --format group the default as I tend to prefer it in all cases.

--format repo reads all the dependencies' package files from disk which has some performance overhead, so it needs to remain opt-in.

@CreativeTechGuy
Copy link
Contributor

reads all the dependencies' package files from disk which has some performance overhead

It's not doing a directory traversal, it's just loading specific package.json files at known paths when needed. Worst case it'll check 3 paths for every package which got updated and load at most one JSON file.

Given that this package does a lot of fetching over the internet, reading some files off of disk seems pretty fast in comparison I'm not sure it's noticeable.


TLDR: I think it's a good default. :)

@raineorshine
Copy link
Owner

Yeah, you're probably right. And zero overhead if we can parallelize it.

I'm still leaning towards opt-in --format repo for aesthetic reasons. (I wish we could do <a href="">...</a> in the terminal.)

--format group is definitely better than the current default though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants