Support for SwiftUI

[vmanot]

Proton currently doesn't offer any SwiftUI ready APIs.

[vmanot]

@rajdeep I'm willing to work on this, let me know if this is within the scope of the project or not.

[rajdeep]

that'd be great @vmanot. I have not been able to manage any time lately. While I do hope to be able to spend more time in near future, I don't think I will be able to get to this any time soon. You may look into this and we can have a discussion once you have an idea on how you plan to approach this.

[vmanot]

@rajdeep I understand - I think I'll develop it as a separate package then (I don't want to diverge too far from master and at the same time intend to use it across a few projects). If/when it reaches maturity, you could consider absorbing it back into the main framework if appropriate.

[rajdeep]

sounds like a plan! thanks again!

[papajyp]

I have been working on a basic swiftui Rich Text Editor. I am lacking lists. I might be able to help. I am interested at least incorporating what you have into my app.

[rajdeep]

that's cool, @papajyp. Please feel free to share any ideas, suggestions or code that you think would help get SwiftUI support.

[writing-shed]

A good starting point for Proton would be a SwiftUI version of EditorView. At the moment I am hosting EditorView in UIViewRepresentable, which works, but is messy and precludes giving EditorView more SwiftUI features.

[vmanot]

@writing-shed I am actively working on this. I'm building a SwiftUI wrapper over Proton (using SwiftUIX), and wouldn't mind open sourcing it if others are interested.

[santi-g-s]

@vmanot That would be great. Would this make proton compatible with native macOS apps? i.e not using catalyst

[jabethfla]

@rajdeep yes! please open source it

[writing-shed]

I have already embedded Proton in a SwiftUI app that I’m developing and it works OK on IOS and MacOS. All I did was use UIViewRepresentable to create the EditorView and let the Coordinator class act as EditorViewDelegate. In all it is 170 lines of code. I have no doubt that Proton can be fully SwiftUIified, and I look forward to what Vatsal does with it.

…

On 6 Jan 2021, at 22:02, santi-g-s ***@***.***> wrote: That would be great. Would this make proton compatible with native macOS apps? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#83 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGAIGCY4HQFJOUM46FZSIYLSYTMYFANCNFSM4VSX2O4Q>.

[santi-g-s]

Does this support non-catalyst macOS apps? Wouldn't it have to be through NSViewRepresentable?

[writing-shed]

I just have a single app targeted to run on iphone, ipad and mac (via catalyst). I haven't tried a non catalyst mac os app. I doubt if it would compile. It only needs uiviewrepresentable if using SwiftUI Best Keith Sent from my iPhone

…

On 7 Jan 2021, at 22:53, santi-g-s ***@***.***> wrote:  Does this support non-catalyst macOS apps? Wouldn't it have to be through NSViewRepresentable? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[santi-g-s]

Hi @vmanot! Any update on how this is going?

[niklasgrewe]

Hi @vmanot any news about proton and swiftui?

[bryan1anderson]

@rajdeep I recommend as a first step we work on a simple example that wraps EditorView in a UIViewRepresentable.
That's pretty straightforward.

I think showing how to do that in the Read me would go along way towards helping people get started.

Here's a sample of mine:

struct ProtonView: View {
    
    @Binding var attributedText: NSAttributedString
    @State var height: CGFloat = 0
    var body: some View {
        ProtonWrapperView(attributedText: $attributedText) { view in
            let height = view.systemLayoutSizeFitting(UIView.layoutFittingExpandedSize).height

            self.height = height
        }
        .frame(height: height)
    }
}

struct ProtonWrapperView: UIViewRepresentable {
    
    @Binding var attributedText: NSAttributedString
    let textDidChange: (EditorView) -> Void

    
    func makeUIView(context: Context) -> EditorView {
        let view = EditorView()
        view.becomeFirstResponder()
        view.attributedText = attributedText
        view.isScrollEnabled = false
        view.setContentCompressionResistancePriority(.required, for: .vertical)

        view.heightAnchor.constraint(greaterThanOrEqualToConstant: 300).isActive = true
        
        DispatchQueue.main.async {
            self.textDidChange(view)
        }
        
        EditorViewContext.shared.delegate = context.coordinator

        return view
    }
    
    func updateUIView(_ view: EditorView, context: Context) {

    }
    
    func makeCoordinator() -> Coordinator {
        Coordinator(self)
    }
    
    class Coordinator: NSObject, EditorViewDelegate {
        var parent: ProtonWrapperView
        
        init(_ parent: ProtonWrapperView) {
            self.parent = parent
        }
        
        func editor(_ editor: EditorView, didChangeTextAt range: NSRange) {
            editor.isScrollEnabled = false
            parent.attributedText = editor.attributedText
            DispatchQueue.main.async {
                self.parent.textDidChange(editor)
            }
        }
    }
}

[wtpalexander]

Agreed. Adding some SwiftUI examples similar to this would be helpful imo!