Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I can move between nested Editors using cursors #3

Open
rjchatfield opened this issue Feb 29, 2020 · 1 comment
Open

As a user, I can move between nested Editors using cursors #3

rjchatfield opened this issue Feb 29, 2020 · 1 comment

Comments

@rjchatfield
Copy link
Collaborator

I believe this will be important in two scenarios.

Imagine two paragraphs with a Panel in between them which contains a paragraph worth of content. If my cursor is half way along the top paragraph, tapping down should move to “the next line” which is either inside the same paragraph or inside the Panel. I’d expect my cursor to jump into the middle of the first line of the Panel.

Imagine we build a Table with a 2-dimensional array of Editors. If I tap down in a cell, I’d expect the cursor to move into the editor below. Similarly, if I move my cursor to the end of the content within a cell, tapping right should jump to the next cell to the right.

I believe we can leverage the protocol used for “us focusable”.

@rajdeep
Copy link
Owner

rajdeep commented Feb 29, 2020

This would be a nice feature. Thanks for the suggestion. I already have in my backlog a ticket to extent EditorViewDelegate didReceiveKey to relay esc key. I am planning to add up/down and right/left to that as well. Once the keys are intercepted, it would be the parent container's responsibility to figure out what to do. This will keep it flexible enough to achieve what you have mentioned and also open enough to be extended even in the ways that we have not yet thought of. What do you think?

rjchatfield pushed a commit to rjchatfield/proton that referenced this issue Jan 16, 2021
BEE-1988 & BEE-1990 crash fixes

* BEE-1988 & BEE-1990 crash fixes

Approved-by: Arthur Semenyutin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants