Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite flag does not work on OS X #75

Open
aelse opened this issue Jul 24, 2019 · 1 comment
Open

Overwrite flag does not work on OS X #75

aelse opened this issue Jul 24, 2019 · 1 comment

Comments

@aelse
Copy link

aelse commented Jul 24, 2019

In the rename function the force overwrite flag is tested after a call to os.Rename, which succeeds in overwriting a file on OS X but not linux. (incoming PR to fix)

@aelse
Copy link
Author

aelse commented Jul 24, 2019

Since opening this issue and PR #76 i see there's already the same fix in #64. It omits the os.Remove call) but this doesn't seem to be necessary (tested os.Create behaviour in OS X and linux and in both cases the file is overwritten). I'll close #76 and #64 looks fine to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant