Downgrade Cypress version to ensure e2e tests pass on npm test

[GoelBiju]

Currently, on the breadcrumbs branch, the e2e tests delivered by Cypress (in headless mode) hang when running npm test.

@louise-davies mentioned that this may be due to this issue being tracked on the Cypress repository and the best option is to downgrade Cypress from version 3.5.0 to 3.4.1.

Acceptance criteria:

• All e2e tests pass when running cypress from command-line/headless mode (i.e. npm test)

[GoelBiju]

This will be addressed when the pull request for the breadcrumbs #70 has been merged.

[GoelBiju]

So at the moment version 3.4.1 of cypress is fine with tests running in their own repository but not at root level. This is an issue that is was fixed by Cypress at cypress-io/cypress#2181 and the cypress version was updated to 3.5.0 in order to fix it.

The issue we are now facing is that we cannot use 3.5.0 or anything above since the headless mode issue is still a problem and we will have to wait for it to be resolved.

[GoelBiju]

I have added fdaf2c0 (mentioned by @louise-davies ) to downgrade to 3.4.1 and not run npm test at root level as a temporary fix to this issue until Cypress have created a fix for it.

The only main disadvantage to using npm test now would be that if a test fails on one repository then the whole build fails as opposed to before continuing and running the others, but the rest can be tested locally if needed.

[GoelBiju]

The fix for this is within the breadcrumbs branch and will be merged in with the breadcrumbs as it currently only affects that branch.

[GoelBiju]

As mentioned by @louise-davies , this pull request on the main Cypress repository may be a solution to this issue. If so and the breadcrumbs branch is already merged by the time the Cypress repository merges it in, a new issue with pull request can be opened to solve it and change back to the old way of testing.