Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads-up: upcoming (helpful) change in setupPHP #212

Closed
jrfnl opened this issue Dec 27, 2021 · 1 comment
Closed

Heads-up: upcoming (helpful) change in setupPHP #212

jrfnl opened this issue Dec 27, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jrfnl
Copy link
Contributor

jrfnl commented Dec 27, 2021

This is just a heads-up and for your information.

Basic premise:

Composer commands when used in CI, should always use the --no-interaction flag, which this action already (correctly) takes care of.

The heads-up:

After a recent discussion about this in the setup-php repo, a change has been made in setup-php to set the COMPOSER_NO_INTERACTION=1 flag (commit shivammathur/setup-php@e7e1eee), which will have the same effect for all composer commands run in a job.

This change is expected to be included in the next release of setup-php.

Impact on this action

I expect that this will/should probably not have any impact on this plugin, as users of this action may not necessarily be using the latest version of setup-php or may possibly not even be using setup-php.

@ramsey Either way, I figured it may be useful for you to know about this change in advance. Please feel free to close this issue if you agree that this upstream change will not impact this action.

@jrfnl jrfnl added the enhancement New feature or request label Dec 27, 2021
@ramsey
Copy link
Owner

ramsey commented Dec 27, 2021

Thanks! I agree this shouldn't affect this action.

@ramsey ramsey closed this as completed Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants