Handle PostgreSQL binary resources #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the reminder, @thePanz. I'll try to take a look very soon. |
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
============================================
+ Coverage 90.25% 90.38% +0.12%
- Complexity 75 76 +1
============================================
Files 7 7
Lines 154 156 +2
============================================
+ Hits 139 141 +2
Misses 15 15
|
|
Sorry for the delay. Thank you for contributing! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PostgreSQL (PDO) returns binary values as resources. Converting those to UUIDs is possible with this change.
Motivation and context
Fixes #225 where the
uuid_binarytype was unusable with PostgreSQL.How has this been tested?
Added 1 new unit test, cross-checked with MySQL 8 and MariaDB 10.
Types of changes
PR checklist