Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node.js to version 18.x #3952

Closed
rak-phillip opened this issue Feb 15, 2023 · 3 comments
Closed

Upgrade Node.js to version 18.x #3952

rak-phillip opened this issue Feb 15, 2023 · 3 comments
Labels
component/dependencies Pull requests that update a dependency file kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API triage/needs-information Further information is requested
Projects

Comments

@rak-phillip
Copy link
Contributor

rak-phillip commented Feb 15, 2023

Node.js 16 will reach end of life on September 11th, 2023. The new version comes with a breaking change to OpenSSL, which breaks builds in Rancher Desktop.

Two common proposed solutions for handling the breaking change in OpenSSL don't appear to work for Rancher Desktop

  1. Update the hash function in webpack: output.hashFunction: "xxhash64 | sha512 | sha256".

    This doesn't have any effect on the behavior at all. It seems to me that this error is happening before webpack begins bundling.

  2. Add --openssl-legacy-provider to dev/build scripts.

    Performing this action raises another error: electron: --openssl-legacy-provider is not allowed in NODE_OPTIONS

More research on an upgrade path is needed.

@rak-phillip rak-phillip added triage/needs-information Further information is requested component/dependencies Pull requests that update a dependency file kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API labels Feb 15, 2023
@rak-phillip rak-phillip added this to the Next milestone Feb 15, 2023
@rak-phillip rak-phillip added this to To do in Stripey via automation Feb 15, 2023
@gaktive
Copy link
Contributor

gaktive commented Feb 17, 2023

@rak-phillip shall we move to this v.Later or how necessary is this for the current release?

@rak-phillip
Copy link
Contributor Author

rak-phillip commented Feb 17, 2023

Yes, I think later is appropriate.

edit:

I think it's important that we have a migration plan before v16 reaches end of life on September 11th, 2023.

@rak-phillip rak-phillip modified the milestones: Next, Later Feb 17, 2023
@jandubois jandubois removed this from the Later milestone Dec 10, 2023
@jandubois
Copy link
Member

We are running node 18 now, and I think there are no outstanding problems with the openssl update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dependencies Pull requests that update a dependency file kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API triage/needs-information Further information is requested
Projects
No open projects
Stripey
To do
Development

Successfully merging a pull request may close this issue.

3 participants