Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forwardport v2.9] Git Clone Error: Empty git-upload-pack-given using SSH or HTTPS to Azure DevOps Repos #2047

Closed
rancherbot opened this issue Jan 8, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@rancherbot
Copy link
Collaborator

This is a forwardport issue for #2043, automatically created via GitHub Actions workflow initiated by @raulcabello

Original issue body:

Rancher Server Setup

  • Rancher version: 2.8

Information about the Cluster

  • Kubernetes version: 1.25.15
  • Cluster Type: Local
  • Hosted: AKS

Describe the bug
Rancher Fleet jobs report: "Error cloning repository: empty git-upload-pack given" when connecting to a previously working Git Repo in Azure DevOps Repos using both SSH and HTTPS authentication.

To Reproduce

  • Upgraded Rancher 2.7.9 to Rancher 2.8

Result

  • Git Repos are stuck in the status Updating Git

Expected Result

  • Git Repos sync like they did in 2.7.9

Screenshots
image

@raulcabello
Copy link
Contributor

QA Template

Solution

Azure DevOps requires capabilities multi_ack / multi_ack_detailed, which are not fully implemented and by default are included in transport.UnsupportedCapabilities. transport.UnsupportedCapabilities have been changed to support that.

Testing

  • Test GitRepos are deployed successfully for git repositories hosted in Azure DevOps.
  • All the other git providers should keep working fine (e.g. github, bitbucket, gitlab)

Additional Info

  • This fix just works on private repositories. We need to wait for go-git to implement v2 protocol in order to support public repositories

@mmartin24
Copy link
Collaborator

QA test report

We currently test daily app deployment with private repos (Azure, Github, Bitbucket, Gitlab) in rancher v2.7-head, v2.8-head and v2.9-head.

  • Check deployment of nginx app over Azure private repo using both ssh and http auth on Rancher v2.9-head (v2.9-c9be13b09329bbee60a5f6419d500198f83c44d1-head ) here with fleet:104.0.0+up0.10.0-rc.11 passing using single node k3s cluster v1.28.8+k3s1
    image

  • Checked deployment over 2.7-head and 2.8-head and then upgraded to 2.9-head and worked as well:
    2 8
    2 9_up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants