Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[forward v0.10][SURE-7047] Support for Azure DevOps Webhook for gitRepos using SSH URL #2352

Closed
thehejik opened this issue Apr 22, 2024 · 1 comment
Closed

[forward v0.10][SURE-7047] Support for Azure DevOps Webhook for gitRepos using SSH URL #2352

thehejik opened this issue Apr 22, 2024 · 1 comment
Assignees
@0xavi0
Labels
kind/bug
Milestone
v2.9.0

Comments

@thehejik
Copy link

thehejik commented Apr 22, 2024 •
edited

forwardport of #2191

This is implemented in v2.8 but apparently missing in v2.9.

Found when testing #1974 on rancher:v2.9-7ba850556909b83061256040c882118653373ff0-head with fleet:104.0.0+up0.10.0-rc.11
@thehejik thehejik added this to the v2.9.0 milestone Apr 22, 2024
@thehejik thehejik mentioned this issue Apr 22, 2024
Open
@manno manno modified the milestones: v2.9.0, v2.10.0 Apr 23, 2024
@manno manno changed the title [forward v2.9][SURE-7047] Support for Azure DevOps Webhook for gitRepos using SSH URL [forward v2.10][SURE-7047] Support for Azure DevOps Webhook for gitRepos using SSH URL Apr 23, 2024
@manno manno changed the title [forward v2.10][SURE-7047] Support for Azure DevOps Webhook for gitRepos using SSH URL [forward v0.10][SURE-7047] Support for Azure DevOps Webhook for gitRepos using SSH URL Apr 23, 2024
@manno manno modified the milestones: v2.10.0, v2.9.0 Apr 23, 2024
@0xavi0 0xavi0 assigned 0xavi0 and unassigned 0xavi0 May 15, 2024
0xavi0 added a commit to 0xavi0/fleet that referenced this issue May 17, 2024
@0xavi0
Forward port. Support for Azure DevOps Webhook for gitRepos using SSH…
3262ffa 
… URL

Forward port of: rancher/gitjob#446
Refers to: rancher#2352

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 mentioned this issue May 17, 2024
Merged
0xavi0 added a commit that referenced this issue May 21, 2024
@0xavi0
Forward port. Support for Azure DevOps Webhook for gitRepos using SSH…
3509d66 
… URL (#2440)

Forward port of: rancher/gitjob#446
Refers to: #2352

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@thehejik
Copy link
Author

I verified this is resolved fixed in rancher:v2.9-c42447977787af1230f82e3dcf92c4895d5723df-head using fleet:104.0.0+up0.10.0-rc.14 with spec.pollingInterval: 48h set in gitrepo.

  • Working fine without webhook auth
  • Working ok with webhook auth credentials secret
  • Correctly doesn't work when wrong auth credentials are send via webhook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xavi0 0xavi0

Labels
kind/bug
Projects
Fleet
Status: ✅ Done
Milestone
v2.9.0
Development

No branches or pull requests
3 participants
@manno @thehejik @0xavi0