Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: make sure metrics work well with sharding #2355

Closed
Tracked by #1408
p-se opened this issue Apr 23, 2024 · 1 comment
Closed
Tracked by #1408

metrics: make sure metrics work well with sharding #2355

p-se opened this issue Apr 23, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@p-se
Copy link
Contributor

p-se commented Apr 23, 2024

We need to ensure that metrics are collected against resources reconciled not just by the unsharded Fleet controller, but also by sharded controllers.

This could be an opportunity to improve shard label naming, for instance by supporting label-based filtering on the unsharded controller (currently not possible with an empty shard value). For instance, we could use ~ instead of an empty string, or simply add a label such as fleet.cattle.io/empty-shard=true or similar.

A new label shard-default with value true for the unsharded controller has been implemented in 436a81d as part of the PR with the implementation of metrics #2172. Metrics still does not work with sharded fleet controllers. This is to be remedied.

This is a follow-up on both #1740 and #1408.

@p-se p-se added the kind/bug label Apr 23, 2024
@p-se p-se self-assigned this Apr 23, 2024
@p-se p-se added this to the v2.9.0 milestone Apr 24, 2024
@weyfonk
Copy link
Contributor

weyfonk commented May 3, 2024

Note: this documentation on how Flux had planned to do it may be useful.

p-se added a commit to p-se/fleet that referenced this issue May 8, 2024
p-se added a commit to p-se/fleet that referenced this issue May 8, 2024
p-se added a commit to p-se/fleet that referenced this issue May 8, 2024
p-se added a commit to p-se/fleet that referenced this issue May 17, 2024
p-se added a commit to p-se/fleet that referenced this issue May 21, 2024
p-se added a commit to p-se/fleet that referenced this issue May 21, 2024
@p-se p-se closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants