Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify sharding label management #2358

Open
2 tasks done
weyfonk opened this issue Apr 23, 2024 · 1 comment
Open
2 tasks done

Clarify sharding label management #2358

weyfonk opened this issue Apr 23, 2024 · 1 comment
Assignees
@manno
Milestone
v2.9.0

Comments

@weyfonk
Copy link
Contributor

weyfonk commented Apr 23, 2024 •
edited by manno

Fleet uses two labels for its current sharding implementation:

  • controllers are labelled with shard=<shard-id>
  • sharded resources bear label fleet.cattle.io/shard=<shard-id>

We should:

  • clarify how we want to name(space) those labels, making them consistent across Fleet, eg:
    • shard.fleet.cattle.io/id=<shard-id>
  • expose those labels in Fleet's public API, to enable users to consume them.

Note: info on how Flux handles sharding.

Follow-up on #1740.
@weyfonk weyfonk added this to the v2.9.0 milestone Apr 24, 2024
@manno
Copy link
Member

manno commented May 27, 2024

controller label:
fleet.cattle.io/shard-id=<shard-id>

sharded resources bear label:
fleet.cattle.io/shard-ref=<shard-id>

@manno manno self-assigned this May 27, 2024
This was referenced May 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manno manno

Labels
None yet
Projects
Fleet
Status: ✅ Done
Milestone
v2.9.0
Development

No branches or pull requests
2 participants
@manno @weyfonk