Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition between gitops and gitrepo controller #2435

Open
4 tasks
manno opened this issue May 16, 2024 · 1 comment
Open
4 tasks

Race condition between gitops and gitrepo controller #2435

manno opened this issue May 16, 2024 · 1 comment
Assignees
@0xavi0
Labels
kind/bug
Milestone
v2.9.0

Comments

@manno
Copy link
Member

manno commented May 16, 2024 •
edited

The gitops gitjob controller needs RBAC from the gitrepo controller.

Move from gitrepo to gitops controller:

  • AuthorizeAndAssignDefaults
  • rbac creation
  • helm values check
  • NewTargetsConfigMap

Basically, only the display/summary status updates remain in the gitrepo controller.

  • SetStatusFromResourceKey
  • UpdateDisplayState
  • SetStatusFromBundles
  • SetStatusFromBundleDeployments
  • gitrepo.Status.Display.ReadyBundleDeployments =

Can we improve the condition updates, so both controllers don't conflict on the same condition?
@manno manno added this to the v2.9.0 milestone May 16, 2024
@manno manno added the kind/bug label May 16, 2024
@manno
Copy link
Member Author

manno commented May 22, 2024

Possible duplicate of #2343

@manno manno mentioned this issue May 22, 2024
Merged
@0xavi0 0xavi0 self-assigned this May 24, 2024
@0xavi0 0xavi0 mentioned this issue May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xavi0 0xavi0

Labels
kind/bug
Projects
Fleet
Status: 🏗 In progress
Milestone
v2.9.0
Development

No branches or pull requests
2 participants
@manno @0xavi0