Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add: Catena, Lyra2, Makwa, yescrypt #3965

Open
wendig0x opened this issue Apr 3, 2024 · 2 comments
Open

Request to add: Catena, Lyra2, Makwa, yescrypt #3965

wendig0x opened this issue Apr 3, 2024 · 2 comments
Labels
enhancement Enhancement or new feature

Comments

@wendig0x
Copy link

wendig0x commented Apr 3, 2024

The Password Hashing Competition had some worthy participants: Catena, Lyra2, Makwa and yescrypt. Maybe they should be added to Botan?

@randombit
Copy link
Owner

The primary criteria for adding an algorithm (beyond someone actually writing the code) is if that algorithm is or will be in use in some real world system or protocol.

The secondary criteria is if the algorithm has some notable benefit compared to other systems such that it's worth including because it should be used in real world systems, even if not currently.

As far as I know none of these hashes qualifies under the first criteria. (Please correct me if I'm wrong about this, this is just based on what I've seen used in the past.) On the second crtieria I don't know enough about these other hashes to have an opinion. Certainly I find both Argon2 and scrypt quite poorly designed so I'm open to the possibility. But it would have to come in an argument of "Attribute X is something that makes algo Z superior to {Argon2,scrypt,bcrypt} in some specific scenario and this attribute is so nice it's worth including not just yet another password hash, but one that's not widely used/known/studied."

@randombit randombit added the enhancement Enhancement or new feature label Apr 4, 2024
@wendig0x
Copy link
Author

wendig0x commented Apr 6, 2024

This is where the contestants are discussed: https://crypto.stackexchange.com/questions/48933/why-did-argon2-win-the-phc
From the looks of it, the best candidate for realization is Catena.

The reason for adding the hash - I believe there should be some choice, not just the "officially endorsed" candidate (Argon2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants