You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not going to do this anytime soon, best to wait for when things are quiet in terms of active PRs. Maybe end of the year around holidays? This is just to track/discuss possible changes. It would be best to make any such changes all at once to avoid churn.
Change AllowShortFunctionsOnASingleLine from Inline to Empty
Change AllowAllArgumentsOnNextLine from true to false
Change AllowAllParametersOfDeclarationOnNextLine from true to false
As with any rules based formatter, sometimes the result of any change is worse formatting vs what was before, but overall I think these would lead to more readable code.
By EOY Github Actions should have Ubuntu 24.04 available and we could consider switching from clang-format 15 to clang-format 17 at the same time.
If we are able to upgrade clang-format
BreakAfterAttributes = Always
BreakBeforeInlineAsmColon = OnlyMultiLine
The text was updated successfully, but these errors were encountered:
Not going to do this anytime soon, best to wait for when things are quiet in terms of active PRs. Maybe end of the year around holidays? This is just to track/discuss possible changes. It would be best to make any such changes all at once to avoid churn.
AllowShortFunctionsOnASingleLine
fromInline
toEmpty
AllowAllArgumentsOnNextLine
fromtrue
tofalse
AllowAllParametersOfDeclarationOnNextLine
fromtrue
tofalse
As with any rules based formatter, sometimes the result of any change is worse formatting vs what was before, but overall I think these would lead to more readable code.
By EOY Github Actions should have Ubuntu 24.04 available and we could consider switching from
clang-format 15
toclang-format 17
at the same time.If we are able to upgrade
clang-format
BreakAfterAttributes = Always
BreakBeforeInlineAsmColon = OnlyMultiLine
The text was updated successfully, but these errors were encountered: