New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ranger crashes when deleting the .git folder of the current folder #2932
Comments
Hello, vonshednob. Could not reproduce your issue using manjaro, kde, foot |
Thanks for trying. Weirdly enough -- I cannot reproduce this anymore either. It must have been some other specific circumstance. 🤔 I guess it's safe to close this issue until a better reproduction scenario comes up. |
I am experiencing same issue. this is log:
|
Yes, this is a bug. To reproduce it, Here is a quick and dirty way to fix the crash. In - if directory.vcs and directory.vcs.track:
+ if directory.vcs and directory.vcs.track and directory.vcs.rootvcs.repotype: I think the problem comes from the lazy evaluation (and caching?) of - @lazy_property
+ @property
def vcs(self):
- if not self._vcs_signal_handler_installed:
- self.settings.signal_bind(
- 'setopt.vcs_aware', self.vcs__reset, # pylint: disable=no-member
- weak=True, autosort=False,
- )
- self._vcs_signal_handler_installed = True
if self.settings.vcs_aware:
return Vcs(self)
return None |
Runtime Environment
en_US.UTF-8
Current Behavior
ranger crashes when deleting a
.git
folder.Expected Behavior
ranger should not crash.
Context
I was trying to delete a
.git
folder.Steps to reproduce
zh
).git
folder (dDy
)Traceback
The text was updated successfully, but these errors were encountered: