Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for react-native-google-analytics-bridge version 6 #297

Open
3 of 14 tasks
kevinsperrine opened this issue Oct 30, 2018 · 1 comment
Open
3 of 14 tasks

Support for react-native-google-analytics-bridge version 6 #297

kevinsperrine opened this issue Oct 30, 2018 · 1 comment

Comments

@kevinsperrine
Copy link

kevinsperrine commented Oct 30, 2018

This is a...

  • 🪲 Bug Report
  • 🚀 Feature Request
  • 📜 Documentation Request

Note: for support questions, please use stackoverflow with the redux-beacon tag. This repository's issues are reserved for feature requests and bug reports.

Which version of Redux Beacon are you using?

  • v2.0.3

Which target(s) are you using?

  • Google Analytics
  • Google Analytics (gtag)
  • React Native Google Analytics
  • Google Tag Manager
  • React Native Google Tag Manager
  • Amplitude
  • Segment
  • Other/Third Party: ...(please specify here)

🚀 📜 What's missing from Redux Beacon that you'd like to add?

Following up on #278 (comment). I didn't realize those hitPayload changes are breaking changes that were added to react-native-google-analytics-bridge version 6. Given this, I suppose any changes we embark on here will require bumping the react-native-google-analytics package to version 2.0 already. It seems the best way to support current users and add the new features from v6 of the bridge. Do you agree, @ttmarek?

Can you help out?

  • 🌟 I am a legend and can get started on a pull request right away given the go-ahead.
  • ⭐ I am a superstar and would like to help out given some guidance.
  • 😞 I won't be able to help out on this one.
@ttmarek
Copy link
Contributor

ttmarek commented Nov 7, 2018

I agree @kevinsperrine. Thanks for bringing this up, it's super helpful. It would have completely passed my radar otherwise.

We should also add the bridge version to the peerDependencies section if you can do that as well. There may be a bit more work here. Feel free to do as much as you can. If you make a pull request with some work I will try to add to it and help out.

I have no problem bumping up to 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants