Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startRow does not work #349

Open
MaarekVarres opened this issue Feb 20, 2024 · 0 comments
Open

startRow does not work #349

MaarekVarres opened this issue Feb 20, 2024 · 0 comments

Comments

@MaarekVarres
Copy link

It seams that there is problem with getting headers if I start reading file lets say on line 155.
This code change is probably nor correct in every scenario but some changes are needed since importing large files in multiple job runs are not possible currently.

My changes are "$k === 1" in importable.php - function importSheet

if ($k >= $this->start_row || $k === 1) {
if ($this->with_header) {
if ($k === 1) {
$headers = $this->toStrings($row);
$count_header = count($headers);
continue;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant