Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the rapidloop/pq fork causes a conflict when using the collector package #23

Open
philmcc opened this issue May 2, 2019 · 2 comments
Open

Comments

@philmcc
Copy link

philmcc commented May 2, 2019

Hi,

When using the collector package with other code that uses the lib/pq standard package, you get an error:

panic: sql: Register called twice for driver postgres

This is due to pgmetrics using the fork of lib/pq, rapidloop/pq.

Is it possible to change this to use the standard library so that it will work with other code?

Thanks

@mdevan
Copy link
Contributor

mdevan commented May 3, 2019

This was done to support SCRAM-SHA-256 which was not available in lib/pq. Now that lib/pq also supports SCRAM-SHA-256, the fork is no longer needed and we should be going back to the upstream implementation.

So yes, will change it back to lib/pq soon.

@philmcc
Copy link
Author

philmcc commented May 3, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants