Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling cleanupCallback multiple times should be ignored instead of reporting back an error #215

Closed
silkentrance opened this issue Jan 24, 2020 · 1 comment
Closed

Calling cleanupCallback multiple times should be ignored instead of reporting back an error #215

silkentrance opened this issue Jan 24, 2020 · 1 comment
Assignees
@silkentrance
Labels
compatibility enhancement

Comments

@silkentrance
Copy link
Collaborator

silkentrance commented Jan 24, 2020 •
edited

changing the existing behaviour will break existing solutions, if they ever relied on the reported error.
at least, we should make a minor release here, given the other breaking enhancements and bug fixes, we should go for a major release, say 1.0.0 :)
@silkentrance silkentrance self-assigned this Jan 24, 2020
@silkentrance
Copy link
Collaborator Author

silkentrance commented Jan 27, 2020 •
edited

already implemented with fix for #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silkentrance silkentrance

Labels
compatibility enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@silkentrance